chore: add generic transactional connection state #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
force-pushed
the
transactional-connection-state
branch
2 times, most recently
from
72d0872 to
3563a09
Compare
Adds data structures for generic transactional connection state. These structures will be used to keep all connection state in one place, making it easier to add new connection variables. This also adds support for transactional connection state; Changes that are made during a transaction are only persisted if the transaction is committed. It also allows for setting temporary (local) values during a transaction. This change is the first step in a multi-step process for moving all connection variables into a generic structure. Following changes will move the other connection variables into this structure, and will add support for executing `set local ...` statements.
olavloite
force-pushed
the
transactional-connection-state
branch
from
3563a09 to
4825aa4
Compare
bhatt4982
reviewed
Sep 2, 2025
| // GetValueOrDefault returns the current value of the property in the given ConnectionState. | ||
| // It returns the default of the property if no value is found. | ||
| func (p *TypedConnectionProperty[T]) GetValueOrDefault(state *ConnectionState) T { | ||
| value, _ := state.value(p /*returnErrForUnknownProperty=*/, false) |
Contributor
There was a problem hiding this comment.
nit: comment should be associated with right param... state.value(p, /returnErrForUnknownProperty=/ false)
Collaborator
Author
There was a problem hiding this comment.
While I agree with you, the Go formatter does not agree with that (and simply does not allow it). It just moves it back to this position automatically.
bhatt4982
reviewed
Sep 2, 2025
| return nil | ||
| } | ||
| } | ||
| return nil |
Contributor
There was a problem hiding this comment.
This should probably return error...
Collaborator
Author
There was a problem hiding this comment.
Thanks for spotting that. Fixed (and added a test case)
bhatt4982
reviewed
Sep 2, 2025
Contributor
bhatt4982
left a comment
bhatt4982
left a comment
There was a problem hiding this comment.
Please check the checkValidValue()...
olavloite
force-pushed
the
transactional-connection-state
branch
from
ce53ec7 to
26fc367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds data structures for generic transactional connection state. These structures will be used to keep all connection state in one place, making it easier to add new connection variables.
This also adds support for transactional connection state; Changes that are made during a transaction are only persisted if the transaction is committed. It also allows for setting temporary (local) values during a transaction.
This change is the first step in a multi-step process for moving all connection variables into a generic structure. Following changes will move the other connection variables into this structure, and will add support for executing
set local ...statements.