Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleWebAuthorizationBroker.AuthorizeAsync - browser will not self-close #482

Closed
GoogleCodeExporter opened this issue Apr 14, 2015 · 7 comments
Assignees

Comments

@GoogleCodeExporter
Copy link

GoogleWebAuthorizationBroker.AuthorizeAsync - browser will not self-close after 
authorisation when Chrome is the default browser.

What steps will reproduce the problem?
  1. Set Chrome as default browser
  2. Use GoogleWebAuthorizationBroker.AuthorizeAsync to obtain a UserCredential response.
  3. The Chrome window/tab shows "Received verification code. Closing..." but does not close. The developer console output window shows: "Scripts may close only the windows that were opened by it."

What is the expected output? What do you see instead?

  When IE is the default browser, the window/tab automatically closes, however Chrome does not. This is likely due to recent changes in Chrome itself:
 http://googlechromereleases.blogspot.com.au/2014/07/stable-channel-update.html
 http://www.shaneweng.com/blog/Close-Popup-Window-in-Chrome
 http://stackoverflow.com/questions/19761241/window-close-and-self-close-do-not-close-the-window-in-chrome#24855795

What version of the product are you using?
  Google.Apis                    1.8.2    
  Google.Apis.Analytics.v3       1.8.1.980
  Google.Apis.Auth               1.8.2    
  Google.Apis.Core               1.8.2    

What is your operating system?
  Windows 7 64 bit

What is your IDE?
  VS 2012

What is the .NET framework version?
  .NET 4.5.1

Please provide any additional information below.

Original issue reported on code.google.com by craig.hu...@gmail.com on 4 Aug 2014 at 4:48

@GoogleCodeExporter
Copy link
Author

I have also seen this over the last few weeks.  .net 4.0 VS 2010.

Original comment by laurl...@gmail.com on 26 Aug 2014 at 7:14

@GoogleCodeExporter
Copy link
Author

Jesse, do you want to own this one?
If you want, go ahead.
If you need more details - let me know.
If you DON'T want - just change the owner back to empty.

Thanks,
Eyal

Original comment by pele...@google.com on 10 Oct 2014 at 2:48

  • Changed state: Accepted
  • Added labels: Milestone-Release1.9.1

@GoogleCodeExporter
Copy link
Author

As long as this auth flow uses an external browser, it won't be possible to 
close the window from JavaScript.

For command-line apps, the best we can do may be to change 
LocalServerCodeReceiver's message to ask the user to close the window.

For GUI apps, we could switch to using an embedded browser control.

Original comment by jmcg...@google.com on 1 Nov 2014 at 12:32

@GoogleCodeExporter
Copy link
Author

Original comment by jmcg...@google.com on 15 Nov 2014 at 1:12

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Original comment by jmcg...@google.com on 19 Nov 2014 at 10:14

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Jesse, can you attach the https://codereview.appspot.com/.... link?
In general when closing an issue add also the code review link.
Thanks!

Original comment by pele...@google.com on 28 Nov 2014 at 10:44

@GoogleCodeExporter
Copy link
Author

https://codereview.appspot.com/162630043/

Original comment by jmcg...@google.com on 29 Nov 2014 at 12:30

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
@jskeet jskeet removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants