Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreaking change to ConfigurableMessageHandler (#592) #631

Merged
merged 4 commits into from Nov 17, 2015

Conversation

Projects
None yet
3 participants
@peleyal
Copy link
Collaborator

commented Nov 14, 2015

In #617, I presented a new breaking change to the library. With this
change we are going to avoid that, by adding back the list getter, which
is OBSOLETE now.

peleyal added some commits Nov 12, 2015

Merge pull request #1 from google/master
Merge from google head
#592 unbreaking change to ConfigurableMessageHandler
In #617, I presented a new breaking change to the library. With this
change we are going to avoid that, by adding back the list getter, which
is OBSOLETE now.

@googlebot googlebot added the cla: yes label Nov 14, 2015

@peleyal peleyal changed the title #592 unbreaking change to ConfigurableMessageHandler Unbreaking change to ConfigurableMessageHandler (#592) Nov 14, 2015

@peleyal peleyal added this to the 1.10 milestone Nov 14, 2015

@peleyal

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 14, 2015

To see the diff between the current version in NuGet to this suggested version, take a look in:
google:1.9.2...peleyal:592
then choose the "File Changed" tab and look for changes in Src/GoogleApis.Core/Apis/Http/ConfigurableMessageHandler.cs.

/// A base class for a client service which provides common mechanism for all services, like
/// serialization and GZip support. Although this class isn't thread-safe (it contains a reference to
/// <see cref="HttpClient"/> which isn't thread-safe itself), it's recommended to create a single service for
/// several server calls.

This comment has been minimized.

Copy link
@mmdriley

mmdriley Nov 15, 2015

Contributor

I could see this being a bit confusing. Maybe simplify to describe the intent:

It should be safe to use a service instance to make server requests concurrently from multiple threads.

This comment has been minimized.

Copy link
@peleyal

peleyal Nov 15, 2015

Author Collaborator

Done.

@mmdriley

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2015

lgtm

peleyal added a commit that referenced this pull request Nov 17, 2015

Merge pull request #631 from peleyal/592
Unbreaking change to ConfigurableMessageHandler (#592)

@peleyal peleyal merged commit 6711b27 into googleapis:master Nov 17, 2015

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.