Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport): increase ReadIdleTimeout #1028

Merged
merged 1 commit into from May 18, 2021
Merged

Conversation

@tritone
Copy link
Contributor

@tritone tritone commented May 18, 2021

Increase this value to comply with CFE rate limit on pings.

Closes googleapis/google-cloud-go#4121

Increase this value to comply with CFE rate limit on pings.

Closes googleapis/google-cloud-go#4121
@tritone tritone requested review from yoshi-approver and googleapis/yoshi-go-admins as code owners May 18, 2021
@google-cla google-cla bot added the cla: yes label May 18, 2021
@tritone tritone requested a review from shollyman May 18, 2021
Copy link
Contributor

@shollyman shollyman left a comment

Disclaimer on LGTM: I don't claim to have full awareness of the magic here, but that seems like a more sensible default generally.

Copy link
Member

@codyoss codyoss left a comment

LGTM

@codyoss codyoss merged commit b3cd013 into googleapis:master May 18, 2021
4 checks passed
4 checks passed
@github-actions
auto-approve
Details
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants