Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport): Add default certificate caching support #721

Merged
merged 9 commits into from Dec 3, 2020

Conversation

@andyrzhao
Copy link
Contributor

@andyrzhao andyrzhao commented Oct 23, 2020

Cache and return the cached certificate as long as it has not expired. This avoids having to exec the cert provider command multiple times in the same session, especially when using a dial pool.

Cache and return the cached certificate as long as it has
not expired. This avoids having to exec the cert provider
command multiple times in the same session, especially
when using a dial pool.
@andyrzhao andyrzhao requested a review from googleapis/yoshi-go-admins as a code owner Oct 23, 2020
@google-cla google-cla bot added the cla: yes label Oct 23, 2020
andyrzhao added 5 commits Oct 23, 2020
transport/cert/default_cert.go Outdated Show resolved Hide resolved
transport/cert/default_cert.go Show resolved Hide resolved
transport/cert/default_cert.go Outdated Show resolved Hide resolved
andyrzhao added 2 commits Nov 23, 2020
@codyoss
codyoss approved these changes Dec 2, 2020
@codyoss
Copy link
Member

@codyoss codyoss commented Dec 2, 2020

@andyrzhao Is this good to me merged?

@andyrzhao
Copy link
Contributor Author

@andyrzhao andyrzhao commented Dec 2, 2020

@codyoss codyoss merged commit caa4d89 into googleapis:master Dec 3, 2020
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
myusuf3 added a commit to agilebits/google-api-go-client that referenced this pull request Dec 4, 2020
)

Cache and return the cached certificate as long as it has
not expired. This avoids having to exec the cert provider
command multiple times in the same session, especially
when using a dial pool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants