-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transport): Add default certificate caching support #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache and return the cached certificate as long as it has not expired. This avoids having to exec the cert provider command multiple times in the same session, especially when using a dial pool.
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Oct 23, 2020
codyoss
reviewed
Oct 28, 2020
shinfan
approved these changes
Nov 10, 2020
codyoss
approved these changes
Dec 2, 2020
@andyrzhao Is this good to me merged? |
codyoss
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 2, 2020
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 2, 2020
Yes, please go ahead and merge. Thanks!
…On Wed, Dec 2, 2020 at 1:12 PM Cody Oss ***@***.***> wrote:
@andyrzhao <https://github.com/andyrzhao> Is this good to me merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#721 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKTSO4YCSVNZ7GPUF72BRTSS2UVTANCNFSM4S5C7WSQ>
.
|
myusuf3
pushed a commit
to agilebits/google-api-go-client
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache and return the cached certificate as long as it has not expired. This avoids having to exec the cert provider command multiple times in the same session, especially when using a dial pool.