Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport): Add default certificate caching support #721

Merged
merged 9 commits into from
Dec 3, 2020

Conversation

andyrzhao
Copy link
Contributor

Cache and return the cached certificate as long as it has not expired. This avoids having to exec the cert provider command multiple times in the same session, especially when using a dial pool.

Cache and return the cached certificate as long as it has
not expired. This avoids having to exec the cert provider
command multiple times in the same session, especially
when using a dial pool.
@andyrzhao andyrzhao requested a review from a team as a code owner October 23, 2020 22:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2020
transport/cert/default_cert.go Outdated Show resolved Hide resolved
transport/cert/default_cert.go Show resolved Hide resolved
transport/cert/default_cert.go Outdated Show resolved Hide resolved
@codyoss
Copy link
Member

codyoss commented Dec 2, 2020

@andyrzhao Is this good to me merged?

@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2020
@andyrzhao
Copy link
Contributor Author

andyrzhao commented Dec 2, 2020 via email

@codyoss codyoss merged commit caa4d89 into googleapis:master Dec 3, 2020
myusuf3 pushed a commit to agilebits/google-api-go-client that referenced this pull request Dec 4, 2020
)

Cache and return the cached certificate as long as it has
not expired. This avoids having to exec the cert provider
command multiple times in the same session, especially
when using a dial pool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants