Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): don't use self-signed JWT with impersonation #788

Merged
merged 6 commits into from Jan 29, 2021

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Dec 11, 2020

The limited audience of the base credential will could cause
failures as it would not be able to comunicate with the iam
credentials api if just default scopes were passed.

The limited audience of the base credential will could cause
failures as it would not be able to comunicate with the iam
credentials api if just default scopes were passed.
@codyoss codyoss requested review from yoshi-approver and googleapis/yoshi-go-admins as code owners Dec 11, 2020
@google-cla google-cla bot added the cla: yes label Dec 11, 2020
internal/creds.go Outdated Show resolved Hide resolved
internal/creds.go Outdated Show resolved Hide resolved
@codyoss codyoss requested a review from tbpg Dec 16, 2020
@codyoss
Copy link
Member Author

@codyoss codyoss commented Jan 11, 2021

@tbpg Could you take a quick look at this when you have a chance.

internal/creds.go Outdated Show resolved Hide resolved
codyoss added 2 commits Jan 28, 2021
…ent into imp-selfsigned
@tbpg
tbpg approved these changes Jan 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1dc7dac into googleapis:master Jan 29, 2021
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@codyoss codyoss deleted the codyoss:imp-selfsigned branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants