Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use markdown style links #789

Merged
merged 7 commits into from Jan 11, 2021
Merged

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Dec 11, 2020

Fixes: #712

Fixes: #712
@codyoss codyoss requested review from yoshi-approver and googleapis/yoshi-go-admins as code owners Dec 11, 2020
@google-cla google-cla bot added the cla: yes label Dec 11, 2020
@codyoss
Copy link
Member Author

@codyoss codyoss commented Dec 11, 2020

Another option here is we could turn something like This is [really important](http://example.com/important) stuff. into This is really important( See http://example.com/important ) stuff.. Thoughts?

@codyoss
Copy link
Member Author

@codyoss codyoss commented Dec 11, 2020

Note manual changes are only in gen.go and gen_test.go.

Copy link
Contributor

@tbpg tbpg left a comment

I think the links are useful. So, it seems sad to just remove them?

@codyoss
Copy link
Member Author

@codyoss codyoss commented Dec 16, 2020

I hear you, WDYT about the "( See http://example.com approach)"?

@tbpg
Copy link
Contributor

@tbpg tbpg commented Dec 16, 2020

Could we do This is really important (http://example.com/important) stuff.?

codyoss added 2 commits Dec 16, 2020
@codyoss codyoss changed the title fix: remove markdown links fix: don't use markdown style links Dec 16, 2020
@codyoss codyoss requested a review from tbpg Dec 16, 2020
@tbpg
tbpg approved these changes Dec 16, 2020
codyoss added 4 commits Jan 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 09ddacb into googleapis:master Jan 11, 2021
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants