Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): don't self-sign JWT when an endpoint provided #847

Merged
merged 1 commit into from Jan 29, 2021

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Jan 29, 2021

This was recently caught by the spanner team. This is a part of the spec.

@codyoss codyoss requested review from bshaffer and tbpg Jan 29, 2021
@codyoss codyoss requested review from yoshi-approver and googleapis/yoshi-go-admins as code owners Jan 29, 2021
@google-cla google-cla bot added the cla: yes label Jan 29, 2021
@codyoss
Copy link
Member Author

@codyoss codyoss commented Jan 29, 2021

cc @olavloite

@tbpg
tbpg approved these changes Jan 29, 2021
@codyoss codyoss merged commit 55f262c into googleapis:master Jan 29, 2021
4 checks passed
4 checks passed
@github-actions
auto-approve
Details
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@codyoss codyoss deleted the codyoss:jwt-fix branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants