Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compute): make MetadataItems.Value a pointer #973

Merged
merged 1 commit into from Apr 7, 2021

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Apr 7, 2021

This is already the case in both the beta and v1 surface.

This is already the case in both the beta and v1 surface.
@codyoss codyoss requested review from yoshi-approver and googleapis/yoshi-go-admins as code owners Apr 7, 2021
@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@codyoss codyoss requested a review from tbpg Apr 7, 2021
@codyoss
Copy link
Member Author

@codyoss codyoss commented Apr 7, 2021

@illfelder
Copy link

@illfelder illfelder commented Apr 7, 2021

Thank you for making this update - it looks good to me!

@tbpg
tbpg approved these changes Apr 7, 2021
Copy link
Contributor

@tbpg tbpg left a comment

LGTM for consistency with other versions -- essentially a bug at this point.

@codyoss codyoss merged commit d8cce34 into googleapis:master Apr 7, 2021
4 checks passed
4 checks passed
@github-actions
auto-approve
Details
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@codyoss codyoss deleted the codyoss:compute-alpha-fix branch Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants