Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details to GoogleJsonResponseExceptions created with GoogleJsonResponseExceptionFactoryTesting #1395

Merged
merged 2 commits into from Oct 21, 2019

Conversation

SUPERCILEX
Copy link
Contributor

@SUPERCILEX SUPERCILEX commented Oct 20, 2019

Currently, GoogleJsonResponseExceptions created with GoogleJsonResponseExceptionFactoryTesting will have null #getDetails().

@SUPERCILEX SUPERCILEX requested a review from as a code owner Oct 20, 2019
@googlebot googlebot added the cla: yes label Oct 20, 2019
@chingor13 chingor13 added the kokoro:run label Oct 21, 2019
@kokoro-team kokoro-team removed the kokoro:run label Oct 21, 2019
Copy link
Collaborator

@chingor13 chingor13 left a comment

Thanks for submitting this.

@chingor13 chingor13 added the kokoro:run label Oct 21, 2019
@kokoro-team kokoro-team removed the kokoro:run label Oct 21, 2019
@chingor13 chingor13 merged commit 1ffdba6 into googleapis:master Oct 21, 2019
5 checks passed
@SUPERCILEX
Copy link
Contributor Author

@SUPERCILEX SUPERCILEX commented Oct 22, 2019

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants