Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grab version from package metadata #1419

Merged
merged 3 commits into from Nov 14, 2019

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Nov 13, 2019

This PR allows the GoogleUtils to inspect its own version at start time. If it's running from a package, it can fetch the version from the package manifest's implementation version. If it's not, it can read it from a properties file created at compile time to read the version.

Note:

  • This is similar to how gax inspects its own version for the x-goog-api-client header.
  • We needed to update the checkstyle plugin to make this pass

@chingor13 chingor13 requested a review from as a code owner Nov 13, 2019
@googlebot googlebot added the cla: yes label Nov 13, 2019
@chingor13 chingor13 merged commit a6c6dec into googleapis:master Nov 14, 2019
6 checks passed
@chingor13 chingor13 deleted the detect-version branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants