Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user-agent should use identifier/version #1425

Merged
merged 2 commits into from Nov 21, 2019

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Nov 20, 2019

Fixes #1426

@chingor13 chingor13 requested a review from as a code owner Nov 20, 2019
@googlebot googlebot added the cla: yes label Nov 20, 2019
Copy link
Member

@codyoss codyoss left a comment

LGTM, does this fix an open issue?

@chingor13 chingor13 merged commit bfb4d9c into googleapis:master Nov 21, 2019
6 checks passed
@chingor13 chingor13 deleted the fix-user-agent branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants