Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update http client #1482

Merged
merged 3 commits into from Jan 31, 2020
Merged

deps: update http client #1482

merged 3 commits into from Jan 31, 2020

Conversation

elharo
Copy link
Collaborator

@elharo elharo commented Jan 28, 2020

@chingor13 @suztomo This one require test changes and was too complex for renovabot to handle

@elharo elharo requested a review from codyoss Jan 28, 2020
@elharo elharo requested a review from as a code owner Jan 28, 2020
@googlebot googlebot added the cla: yes label Jan 28, 2020
assertEquals(expectedOutput, out.toString("UTF-8"));
String actual = out.toString("UTF-8");
assertTrue(actual + "\n does not contain \n" + part1, actual.contains(part1));
assertTrue(actual.contains(part2));
Copy link
Member

@suztomo suztomo Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add source code comment what is in-between part1 and part2?

Copy link
Collaborator Author

@elharo elharo Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@elharo elharo changed the title update http client deps: update http client Jan 28, 2020
@elharo elharo requested review from kolea2 and removed request for codyoss Jan 28, 2020
Copy link
Collaborator Author

@elharo elharo left a comment

Ping

@chingor13 chingor13 merged commit 232785a into master Jan 31, 2020
6 checks passed
@chingor13 chingor13 deleted the http branch Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants