Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup checkstyle import rules #1503

Merged
merged 2 commits into from Mar 13, 2020
Merged

Conversation

suraj-qlogic
Copy link
Contributor

@suraj-qlogic suraj-qlogic commented Mar 9, 2020

Fixes #1466

@suraj-qlogic suraj-qlogic requested a review from as a code owner Mar 9, 2020
@googlebot googlebot added the cla: yes label Mar 9, 2020
@suraj-qlogic suraj-qlogic changed the title fix : cleanup checkstyle import rules fix: cleanup checkstyle import rules Mar 9, 2020
@athakor athakor added the kokoro:force-run label Mar 9, 2020
@kokoro-team kokoro-team removed the kokoro:force-run label Mar 9, 2020
checkstyle.xml Show resolved Hide resolved
checkstyle.xml Show resolved Hide resolved
checkstyle.xml Show resolved Hide resolved
@suraj-qlogic suraj-qlogic requested a review from elharo Mar 11, 2020
@athakor athakor added kokoro:force-run and removed kokoro:force-run labels Mar 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run label Mar 11, 2020
@@ -52,6 +52,15 @@ page at http://checkstyle.sourceforge.net/config.html -->
<property name="severity" value="error"/>
</module>

<module name="ImportOrder">
Copy link
Collaborator

@elharo elharo Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but perhaps what really needs to be updated is this:

https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml

Why do we have to customize this in this project?

Copy link
Contributor Author

@suraj-qlogic suraj-qlogic Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"@elharo The customization was needed because we do not have formatter plugin enabled in this repository. Due to that import order are not structured properly.

I am planning to enable the formatter plugin after that we would not have to customize this configuration.

I will open a separate PR for that once that is merged will rebase this PR."

@suraj-qlogic suraj-qlogic requested a review from elharo Mar 12, 2020
elharo
elharo approved these changes Mar 12, 2020
@elharo elharo merged commit ce22c0e into googleapis:master Mar 13, 2020
7 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 8, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.30.10](https://www.github.com/googleapis/google-api-java-client/compare/v1.30.9...v1.30.10) (2020-07-08)


### Bug Fixes

* cleanup checkstyle import rules ([#1503](https://www.github.com/googleapis/google-api-java-client/issues/1503)) ([ce22c0e](https://www.github.com/googleapis/google-api-java-client/commit/ce22c0ea7d02bd1807eae0076bfe55db1a3b754c))
* cleanup commented code of version control ([#1504](https://www.github.com/googleapis/google-api-java-client/issues/1504)) ([5b1968d](https://www.github.com/googleapis/google-api-java-client/commit/5b1968d7bb05affd211b3403a6acc18c3d0c23d9))


### Dependencies

* remove excess dependencies ([#1502](https://www.github.com/googleapis/google-api-java-client/issues/1502)) ([dbe6287](https://www.github.com/googleapis/google-api-java-client/commit/dbe6287dac5b7340827a03c0977ad8f350b58eae))
* update dependency com.google.oauth-client:google-oauth-client-bom to v1.31.0 ([#1544](https://www.github.com/googleapis/google-api-java-client/issues/1544)) ([ebab80d](https://www.github.com/googleapis/google-api-java-client/commit/ebab80d1fec30bde241a5cb7a3146c89aca5359c))
* update dependency com.google.protobuf:protobuf-java to v3.12.2 ([#1527](https://www.github.com/googleapis/google-api-java-client/issues/1527)) ([a4cdec7](https://www.github.com/googleapis/google-api-java-client/commit/a4cdec7afd3c5fb1b6cb4de05021e156dd9d0a14))
* update google-http-client to v1.36.0 ([#1551](https://www.github.com/googleapis/google-api-java-client/issues/1551)) ([01c635a](https://www.github.com/googleapis/google-api-java-client/commit/01c635a21fc3d7b549b6a19cbf3359cacf04ef47))
* update oauth client ([#1499](https://www.github.com/googleapis/google-api-java-client/issues/1499)) ([b9c222c](https://www.github.com/googleapis/google-api-java-client/commit/b9c222cfdc4578dabca48cfbe64068f4f70d3b18))
* update to Guava 29.0 ([#1516](https://www.github.com/googleapis/google-api-java-client/issues/1516)) ([fda223d](https://www.github.com/googleapis/google-api-java-client/commit/fda223d5da5076396bc896db3227facde17e89e5))


### Documentation

* removes reference to deprecated service (Google+) ([#1530](https://www.github.com/googleapis/google-api-java-client/issues/1530)) ([b257207](https://www.github.com/googleapis/google-api-java-client/commit/b2572075418dbbb86b9da8901184c72966464520))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants