Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: socketfactory not registered for apache #1637

Merged
merged 2 commits into from Nov 16, 2020
Merged

fix: socketfactory not registered for apache #1637

merged 2 commits into from Nov 16, 2020

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Nov 13, 2020

For GoogleApacheHttpTransport, socketFactory has to be registered for https, and provided to connectionManager. This PR does the following:

  • register socket factory for http and https, and pass to connection manager (reference)
  • removed .setSSLSocketFactory(socketFactory) from the chain of calls after HttpClientBuilder.create(), since it will be overwritten by .setConnectionManager(connectionManager)

@arithmetic1728 arithmetic1728 requested a review from as a code owner Nov 13, 2020
@google-cla google-cla bot added the cla: yes label Nov 13, 2020
Copy link
Collaborator

@elharo elharo left a comment

This could use a test.

@arithmetic1728
Copy link
Contributor Author

@arithmetic1728 arithmetic1728 commented Nov 13, 2020

This could use a test.

Refactored the code and added test.

@chingor13 chingor13 merged commit e886efa into googleapis:master Nov 16, 2020
7 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants