Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Gson instead of Jackson #1661

Merged
merged 5 commits into from Jan 14, 2021
Merged

fix: use Gson instead of Jackson #1661

merged 5 commits into from Jan 14, 2021

Conversation

elharo
Copy link
Collaborator

@elharo elharo commented Jan 6, 2021

@elharo elharo requested a review from BenWhitehead Jan 6, 2021
@elharo elharo requested a review from as a code owner Jan 6, 2021
@google-cla google-cla bot added the cla: yes label Jan 6, 2021
@elharo elharo changed the title use Gson instead of Jackson fix: use Gson instead of Jackson Jan 11, 2021
Copy link
Collaborator Author

@elharo elharo left a comment

Ping ping ping

@chingor13 chingor13 merged commit 63ed2ca into master Jan 14, 2021
7 checks passed
@chingor13 chingor13 deleted the jackson branch Jan 14, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 14, 2021
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.31.2](https://www.github.com/googleapis/google-api-java-client/compare/v1.31.1...v1.31.2) (2021-01-14)


### Bug Fixes

* remove unused code ([#1664](https://www.github.com/googleapis/google-api-java-client/issues/1664)) ([3e9169f](https://www.github.com/googleapis/google-api-java-client/commit/3e9169f1af87dd947d24440f82fd4e0d7d4e4e5a))
* use Gson instead of Jackson ([#1661](https://www.github.com/googleapis/google-api-java-client/issues/1661)) ([63ed2ca](https://www.github.com/googleapis/google-api-java-client/commit/63ed2caecc200a407ef40b249bed158f18e2c5ae))


### Documentation

* Update the documentation link for GoogleCredential from deprecated version to newer version ([#1652](https://www.github.com/googleapis/google-api-java-client/issues/1652)) ([98db6ca](https://www.github.com/googleapis/google-api-java-client/commit/98db6ca0113396e715894a083227f062269ca93d))


### Dependencies

* update Guava to 30.0 ([#1645](https://www.github.com/googleapis/google-api-java-client/issues/1645)) ([9e34f37](https://www.github.com/googleapis/google-api-java-client/commit/9e34f37e2ef667507e03cb2d495b2c945851eb30))
* update Guava to 30.1 ([#1658](https://www.github.com/googleapis/google-api-java-client/issues/1658)) ([677011e](https://www.github.com/googleapis/google-api-java-client/commit/677011ea4ec40e85d6e219de4e0d8d095b40acd8))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@hiranya911
Copy link

@hiranya911 hiranya911 commented Apr 28, 2021

@chingor13 @elharo

Can you share some context on why this change was made? This change is making it difficult for us (Firebase) to upgrade our SDK dependency from Google API client 1.30.x to 1.31.x. The use of Gson significantly changes how certain JSON input is handled, which is causing numerous test failures in our code.

@elharo
Copy link
Collaborator Author

@elharo elharo commented Apr 28, 2021

go/json-madness

@hiranya911
Copy link

@hiranya911 hiranya911 commented Apr 28, 2021

Thanks @elharo. I've submitted a detailed bug report with our findings at #1779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants