Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): fix typing for GaData#columnHeaders #162

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Kocal
Copy link

Kocal commented Mar 1, 2019

Actually, GaData#columnHeaders is an array of Google_Service_Analytics_GaDataColumnHeaders.
This PR fix the typing of getColumnHeaders() and setColumnHeaders() methods.

ga_data

@googlebot

This comment has been minimized.

Copy link

googlebot commented Mar 1, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Mar 1, 2019

@Kocal

This comment has been minimized.

Copy link
Author

Kocal commented Mar 1, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Mar 1, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 1, 2019

@jdpedrie

This comment has been minimized.

Copy link
Member

jdpedrie commented Mar 1, 2019

Thanks for the contribution. Unfortunately, the code you're modifying is automatically generated and these changes will be overwritten by future updates, so we cannot accept pull requests for these files.

We are planning improvements to the code generator which we expect will fix this issue, amongst others.

I'm sorry for the inconvenience!

@jdpedrie jdpedrie closed this Mar 1, 2019

@Kocal

This comment has been minimized.

Copy link
Author

Kocal commented Mar 1, 2019

Ah, unlucky 😕

That explain why I don't see any logic nor tests, but only DTO 🤔

@Kocal Kocal deleted the Kocal:fix/analytics-column-headers branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.