Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to toggle API format version #1644

Merged
merged 6 commits into from Jun 14, 2019

Conversation

@jdpedrie
Copy link
Member

commented May 29, 2019

Fixes #1642.

Usage:

$client = new Google_Client([
    'api_format_v2' => true
]);

@jdpedrie jdpedrie requested a review from dwsupplee Jun 13, 2019

Clicked wrong button

'api_format_v2' => true
]);
$guzzle = $this->prophesize('Google_Client');

This comment has been minimized.

Copy link
@dwsupplee

dwsupplee Jun 13, 2019

Member

Can we use $this->getMock() here for consistency with the rest of the tests?

This comment has been minimized.

Copy link
@jdpedrie

jdpedrie Jun 13, 2019

Author Member

done

This comment has been minimized.

Copy link
@dwsupplee

dwsupplee Jun 13, 2019

Member

Thanks!

@jdpedrie jdpedrie force-pushed the jdpedrie:add-api-format-version-option branch from 718e54c to fd6b0d2 Jun 14, 2019

jdpedrie added 2 commits Jun 14, 2019

@jdpedrie jdpedrie merged commit 2d11de3 into googleapis:master Jun 14, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jdpedrie jdpedrie deleted the jdpedrie:add-api-format-version-option branch Jun 14, 2019

This was referenced Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.