adds 1-second leeway to JWT validation to prevent intermittent except…

[bshaffer]

…ions

[jmichalek132]

Should it be fixed in newest version?

[bshaffer]

@Kak3n v2.0.0-RC5 and on have had this change.

[jmichalek132]

thanks ok.

2016-05-25 18:49 GMT+02:00 Brent Shaffer notifications@github.com:

@Kak3n https://github.com/Kak3n v2.0.0-RC5
https://github.com/google/google-api-php-client/releases and on have
had this change.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#828 (comment)

[YuanXiong]

On my server, the system time is 2 min prior to the current time so I got this problem. The system admin may have to run the ntp service for date updates.

[jrd-lewis]

Mine shows 5 hours later than what what the Google Token returns, even using the latest version.

[bshaffer]

@jslewis90 I imagine this is an issue with your server's date/time configuration.

[liebsen]

Now is impossible to set leeway outside vendor. Please rollback this fix.

[bshaffer]

@Martinfree You're right, this is not an optimal solution because it pollutes global scope. I'll submit a fix that ensures the adjustment is localized. It would be great if the Firebase\JWT class made leeway configurable per instance as well as statically.

[liebsen]

@bshaffer thank you for considering my suggestion. Cheers.

[hamzawain7]

In google-api-php-client/src/Google/AccessToken/Verify.php line 213 you are not adding 1 to JWT leeway like you mentioned in the comments but rather setting it to 1. Kindly fix it.
`
if (property_exists($jwtClass, 'leeway')) {
// adds 1 second to JWT leeway
// @see #827
$jwtClass::$leeway = 1;
}

`

[dyegonery]

This solution didn't worked with me. So, I tried adding 60 seconds to JWT leeway:
if (property_exists($jwtClass, 'leeway')) {
// adds 1 second to JWT leeway
// @see #827
$jwtClass::$leeway += 60;
}

[ilyasdemirtas]

Hello,

I have that same problem me too, The problem is solving when i changing $leeway variable value as "+=60", but i do not want change in core file of package. But i don't find any way overwrite this variable on another place.

There is any way changing that variable another place?

I'm using 2.1.2 version on laravel as package.

[perials]

@fg-developer You can pass a custom JWT object to Google_Client.

$jwt = new \Firebase\JWT\JWT;
$jwt::$leeway = 60; // adjust this value

// we explicitly pass jwt object whose leeway is set to 60
$this->client = new \Google_Client(['jwt' => $jwt]);

Refer this post.