Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with batch readme example #1002

Closed
fabtjar opened this issue Aug 12, 2020 · 2 comments
Closed

Issues with batch readme example #1002

fabtjar opened this issue Aug 12, 2020 · 2 comments
Assignees

Comments

@fabtjar
Copy link

@fabtjar fabtjar commented Aug 12, 2020

On the batch readme there are examples on how to make a batch request:
https://github.com/googleapis/google-api-python-client/blob/master/docs/batch.md

One of the lines is: batch.execute(http=http)
I'm not sure where the http is coming from.

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 12, 2020

HI @fabtjar, the http argument is optional. I've opened a PR to remove it.

@fabtjar
Copy link
Author

@fabtjar fabtjar commented Aug 12, 2020

Cheers @busunkim96 👍

gcf-merge-on-green bot pushed a commit that referenced this issue Sep 1, 2020
`http=http` is optional

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/google-api-python-client/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #1002  🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants