Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Discovery Document doesn't support retry mechanism #848

Closed
mik-laj opened this issue Mar 22, 2020 · 0 comments
Closed

Fetch Discovery Document doesn't support retry mechanism #848

mik-laj opened this issue Mar 22, 2020 · 0 comments

Comments

@mik-laj
Copy link
Contributor

@mik-laj mik-laj commented Mar 22, 2020

The library currently supports retrying requests when an external API operation is performed.
https://github.com/googleapis/google-api-python-client/blob/master/googleapiclient/http.py#L967-L977
https://github.com/googleapis/google-api-python-client/blob/master/googleapiclient/http.py#L172
However, this does not happen when sending the first request to the Discovery API.
https://github.com/googleapis/google-api-python-client/blob/master/googleapiclient/discovery.py#L282

Environment details

  • OS: Linux/MacOS
  • Python version: All
  • pip version: All
  • google-api-python-client version: google-api-python-client

Steps to reproduce

  1. Create any service object
  2. If a connection problem occurs, the request will not be retried
DFrenkel added a commit to DFrenkel/google-api-python-client that referenced this issue Jul 10, 2020
Adding ability for discovery to retry on eligible http errors
and connection problems with randomized exponential backoff.

Also:
 * DRYing discovery tests to avoid warnings when reading test data.
 * Updating .gitignore

Fixes: googleapis#848
busunkim96 pushed a commit that referenced this issue Jul 15, 2020
Adding ability for discovery to retry on eligible http errors
and connection problems with randomized exponential backoff.

Also:
 * DRYing discovery tests to avoid warnings when reading test data.
 * Updating .gitignore

Fixes: #848
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.