Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove http from batch execute docs #1003

merged 2 commits into from Sep 1, 2020


Copy link

@busunkim96 busunkim96 commented Aug 12, 2020

http=http is optional

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1002 馃

`http=http` is optional
@google-cla google-cla bot added the cla: yes label Aug 12, 2020
@busunkim96 busunkim96 requested a review from plamut Aug 12, 2020
plamut approved these changes Sep 1, 2020
Copy link

@plamut plamut left a comment

LGTM, there's no http to pass in.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 5028fe7 into master Sep 1, 2020
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants