Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update setup.py to install httplib2>=0.15.0 #1050

Merged
merged 2 commits into from Sep 29, 2020

Conversation

@tomchop
Copy link
Contributor

@tomchop tomchop commented Sep 28, 2020

I ran into the same issue described here: #1047

  File "/usr/local/lib/python3.6/dist-packages/googleapiclient/_helpers.py", line 134, in positional_wrapper
    return wrapped(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/googleapiclient/discovery.py", line 300, in build
    discovery_http.close()
AttributeError: 'Http' object has no attribute 'close'

From that same issue:

Having a look at httplib2 changelog, close() method appeared in v0.15.0
@tomchop tomchop requested a review from as a code owner Sep 28, 2020
@google-cla google-cla bot added the cla: yes label Sep 28, 2020
@tomchop tomchop marked this pull request as draft Sep 28, 2020
@tomchop tomchop force-pushed the tomchop-patch-1 branch from cef0b48 to ec90332 Sep 28, 2020
@tomchop tomchop changed the title Update setup.py Update setup.py to install httplib2>=0.15.0 Sep 28, 2020
@tomchop tomchop marked this pull request as ready for review Sep 28, 2020
@@ -38,7 +38,7 @@
# NOTE: Apache Beam tests depend on this library and cannot
# currently upgrade their httplib2 version.
# Please see https://github.com/googleapis/google-api-python-client/pull/841
"httplib2>=0.9.2,<1dev",
"httplib2>=0.15.0,<1dev",
Copy link
Contributor

@busunkim96 busunkim96 Sep 28, 2020

@aaltay Is it alright to bump this now?

Copy link

@aaltay aaltay Sep 28, 2020

I believe it can be bumped now. Beam has 'httplib2>=0.8,<0.18.0', as the new range now. (https://github.com/apache/beam/blob/8bedfd402ccd1336f2b40fad58cd5833cecb9638/sdks/python/setup.py#L150)

Do you remember what was the specific problem?

(/cc @tvalentyn in case he remembers.)

Yes, no need to restrict this for Beam reasons anymore.
https://issues.apache.org/jira/browse/BEAM-9819 has some context for prior restrictions.

Copy link
Contributor

@busunkim96 busunkim96 Sep 28, 2020

Thanks!

@tomchop Could you delete the comments on 38-40 about httplib2?

Copy link
Contributor Author

@tomchop tomchop Sep 28, 2020

@busunkim96 Done!

@tomchop tomchop changed the title Update setup.py to install httplib2>=0.15.0 fix: Update setup.py to install httplib2>=0.15.0 Sep 28, 2020
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Thank you @tomchop!

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Sep 28, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@busunkim96 busunkim96 merged commit c00f70d into googleapis:master Sep 29, 2020
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants