Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't raise when downloading zero byte files #1074

Merged
merged 1 commit into from Oct 22, 2020

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Oct 22, 2020

Don't raise on 416 Range Not Satisfied if there is no content to download. This is similar to fix in resumable media googleapis/google-resumable-media-python#86.

Fixes #638

@busunkim96 busunkim96 requested a review from arithmetic1728 Oct 22, 2020
@busunkim96 busunkim96 requested a review from googleapis/yoshi-python as a code owner Oct 22, 2020
@google-cla google-cla bot added the cla: yes label Oct 22, 2020
@busunkim96 busunkim96 merged commit 86d8788 into googleapis:master Oct 22, 2020
3 of 4 checks passed
3 of 4 checks passed
Kokoro docs-presubmit Build failed
Details
Kokoro Build successful
Details
cla/google All necessary CLAs are signed
conventionalcommits.org
Details
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.