Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change error parsing to check for 'message' #1083

Merged
merged 4 commits into from Nov 8, 2020

Conversation

@mm326
Copy link
Contributor

@mm326 mm326 commented Nov 7, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1082 馃

@mm326 mm326 requested a review from as a code owner Nov 7, 2020
@google-cla
Copy link

@google-cla google-cla bot commented Nov 7, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 7, 2020
@mm326
Copy link
Contributor Author

@mm326 mm326 commented Nov 7, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 7, 2020
@mm326 mm326 changed the title Issue-1082: Change error parsing to check for 'message' docs: Change error parsing to check for 'message' Nov 7, 2020
@parthea parthea self-requested a review Nov 8, 2020
Copy link
Contributor

@parthea parthea left a comment

Thanks for adding this @mm326! Just minor observations regarding formatting, otherwise looks good!

googleapiclient/errors.py Outdated Show resolved Hide resolved
tests/test_errors.py Outdated Show resolved Hide resolved
tests/test_errors.py Outdated Show resolved Hide resolved
@mm326 mm326 requested a review from parthea Nov 8, 2020
parthea
parthea approved these changes Nov 8, 2020
Copy link
Contributor

@parthea parthea left a comment

LGTM, thanks @mm326 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants