Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MediaFileUpload error if file does not exist #1127


Copy link

@parthea parthea commented Dec 7, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #798 馃

@parthea parthea requested a review from busunkim96 Dec 7, 2020
@parthea parthea requested a review from googleapis/yoshi-python as a code owner Dec 7, 2020
@parthea parthea self-assigned this Dec 7, 2020
@google-cla google-cla bot added the cla: yes label Dec 7, 2020
Copy link

@busunkim96 busunkim96 left a comment

LGTM. Could you add a new unit test to check the case where no file exists?

@parthea parthea force-pushed the parthea:fix-mediafileupload-invalid-file-exception branch from 0550363 to 7acba97 Dec 9, 2020
Copy link

@busunkim96 busunkim96 commented Dec 9, 2020

Looks like the 2.7 tests are failing, let's merge #961 first.

Copy link
Contributor Author

@parthea parthea commented Dec 9, 2020

Hi @busunkim96,

Please can you take a look?

@gcf-merge-on-green gcf-merge-on-green bot merged commit 2c6d029 into googleapis:master Dec 9, 2020
3 checks passed
3 checks passed
Kokoro Build successful
cla/google All necessary CLAs are signed
@parthea parthea deleted the parthea:fix-mediafileupload-invalid-file-exception branch Dec 13, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 3, 2021
馃 I have created a release \*beep\* \*boop\* 
## [2.0.0]( (2021-03-03)


* **deps:** require 3.6+ (#961)

### Features

* Add support for using static discovery documents ([#1109]( ([32d1c59](
* Update to copy discovery files from discovery-artifact-manager ([#1104]( ([af918e8](

### Bug Fixes

* Catch ECONNRESET and other errors more reliably ([#1147]( ([ae9cd99](
* **deps:** add upper-bound google-auth dependency ([#1180]( ([c687f42](
* handle error on service not enabled ([#1117]( ([c691283](
* Improve support for error_details ([#1126]( ([e6a1da3](
* MediaFileUpload error if file does not exist ([#1127]( ([2c6d029](
* replace deprecated socket.error with OSError ([#1161]( ([b7b9986](
* Use logging level info when file_cache is not available ([#1125]( ([0b32e69](

### Miscellaneous Chores

* **deps:** require 3.6+ ([#961]( ([8325d24](

### Documentation

* add networkconnectivity v1alpha1 ([#1176]( ([91b61d3](
* Delete redundant ([#1142]( ([70bc6c9](
* fix MediaIoBaseUpload broken link ([#1112]( ([334b6e6](
* fix regression with incorrect args order in docs ([#1141]( ([4249a7b](
* fix typo in thread safety example code ([#1100]( ([5ae088d](
* Reduce noisy changes in docs regen ([#1135]( ([b1b0c83](
* update docs/dyn ([#1096]( ([c2228be](
* update guidance on service accounts ([#1120]( ([b2ea122](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants