Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add static discovery docs #1216

Merged
merged 2 commits into from Mar 4, 2021
Merged

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Mar 4, 2021

Fixes #1214

The MANIFEST.in controls which files are included in the published package.

You can verify that this fixes the problem (missing discovery docs leading to failing discovery.build() calls) by building the package and installing the library from the tarfile.

  • python3 -m venv env
  • source env/bin/activate
  • python3 -m setup.py sdist
  • python3 -m pip install dist/google-api-python-client-2.0.0.tar.gz
(env) busunkim@busunkim:~/github/google-api-python-client$ python3
Python 3.6.9 (default, Feb 24 2020, 21:10:07) 
[GCC 9.2.1 20190909] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import googleapiclient
>>> from googleapiclient import discovery
>>> client = discovery.build("cloudprofiler", "v2")
>>> 
@busunkim96 busunkim96 requested a review from as a code owner Mar 4, 2021
@google-cla google-cla bot added the cla: yes label Mar 4, 2021
parthea
parthea approved these changes Mar 4, 2021
Copy link
Contributor

@parthea parthea left a comment

LGTM, Thanks @busunkim96 !

@jdelalande
Copy link

@jdelalande jdelalande commented Mar 8, 2021

Hello,
it seams that i am having a similar issue with building service with "mybusiness" on "v4". Do you have any idea how i could fix it ? should mention a specific discovery ? (nb : was using this one: "https://developers.google.com/my-business/samples/mybusiness_google_rest_v4p5.json")
Thanks

@busunkim96
Copy link
Contributor Author

@busunkim96 busunkim96 commented Mar 8, 2021

@jdelalande Please see #1225

@enkeyz
Copy link

@enkeyz enkeyz commented Mar 8, 2021

@jdelalande Please see #1225

Where can I find an API's discovery url? My issue: #1238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants