Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include discovery artifacts in published package #1221

Merged

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Mar 4, 2021

Fixes #1214 馃

I was able to re-create the issue by using the following steps.

  1. Create a clean pyenv environment
  2. Download google-api-python-client-2.0.1 from PyPi here and unzip it
  3. Install it using pip install <Unzipped Directory>
  4. Confirm discovery.build() fails on any call

To Verify the fix, repeat the steps above, but apply the update in this PR prior to installing the library.

@parthea parthea requested a review from as a code owner Mar 4, 2021
@google-cla google-cla bot added the cla: yes label Mar 4, 2021
@parthea parthea requested a review from busunkim96 Mar 4, 2021
@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Mar 4, 2021

Confirmed that the fix works for me locally. Thanks @parthea!

@gcf-merge-on-green gcf-merge-on-green bot merged commit ad618d0 into master Mar 4, 2021
3 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-missing-documents-in-published-version branch Mar 4, 2021
parthea added a commit that referenced this issue Apr 20, 2021
parthea added a commit that referenced this issue Apr 20, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 20, 2021
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/google-api-python-client/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #1235 馃

In an attempt to verify that this is a fix for #1235  I'm going push a commit that removes the fix from #1221 in this PR and confirm that the checks fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants