Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct api version in #1258

merged 1 commit into from Mar 18, 2021

fix: correct api version in #1258

merged 1 commit into from Mar 18, 2021


Copy link

@ryan4yin ryan4yin commented Mar 18, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@ryan4yin ryan4yin requested a review from as a code owner Mar 18, 2021
Copy link

@google-cla google-cla bot commented Mar 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 18, 2021
Copy link
Contributor Author

@ryan4yin ryan4yin commented Mar 18, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 18, 2021
Copy link

@parthea parthea left a comment


Copy link

@parthea parthea commented Mar 18, 2021

Thanks for fixing this, @ryan4yin!

@gcf-merge-on-green gcf-merge-on-green bot merged commit d1a255f into googleapis:master Mar 18, 2021
3 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 31, 2021
🤖 I have created a release \*beep\* \*boop\*
## [2.1.0]( (2021-03-31)

### Features

* add status_code property on http error handling ([#1185]( ([db2a766](

### Bug Fixes

* Change default of `static_discovery` when `discoveryServiceUrl` set ([#1261]( ([3b4f2e2](
* correct api version in ([#1258]( ([d1a255f](
* fix .close() ([#1231]( ([a9583f7](
* Resolve issue where num_retries would have no effect ([#1244]( ([c518472](

### Documentation

* Distinguish between public/private docs in 2.0 guide ([#1226]( ([a6f1706](
* Update README to promote cloud client libraries ([#1252]( ([22807c9](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants