Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change default of static_discovery when discoveryServiceUrl set #1261


Copy link

@parthea parthea commented Mar 19, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1225 馃

@parthea parthea requested a review from as a code owner Mar 19, 2021
@google-cla google-cla bot added the cla: yes label Mar 19, 2021
@parthea parthea requested a review from busunkim96 Mar 19, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3b4f2e2 into master Mar 19, 2021
3 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the assume-static-discovery-false-when-discoveryServiceUrl-specified branch Mar 19, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 31, 2021
馃 I have created a release \*beep\* \*boop\*
## [2.1.0]( (2021-03-31)

### Features

* add status_code property on http error handling ([#1185]( ([db2a766](

### Bug Fixes

* Change default of `static_discovery` when `discoveryServiceUrl` set ([#1261]( ([3b4f2e2](
* correct api version in ([#1258]( ([d1a255f](
* fix .close() ([#1231]( ([a9583f7](
* Resolve issue where num_retries would have no effect ([#1244]( ([c518472](

### Documentation

* Distinguish between public/private docs in 2.0 guide ([#1226]( ([a6f1706](
* Update README to promote cloud client libraries ([#1252]( ([22807c9](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants