Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update nox file to build and test wheels #1295

Merged
merged 4 commits into from Apr 20, 2021
Merged

test: update nox file to build and test wheels #1295

merged 4 commits into from Apr 20, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Apr 20, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1235 馃

In an attempt to verify that this is a fix for #1235 I'm going push a commit that removes the fix from #1221 in this PR and confirm that the checks fail.

@parthea parthea requested a review from a team as a code owner April 20, 2021 12:53
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2021
@parthea parthea self-assigned this Apr 20, 2021
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2021
@parthea
Copy link
Contributor Author

parthea commented Apr 20, 2021 •
edited

I've confirmed that unit tests fail with error ../lib/python3.9/site-packages/googleapiclient/discovery.py:405: UnknownApiNameOrVersion without the fix from #1221. See log.

@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2021
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2021
@parthea parthea requested a review from busunkim96 April 20, 2021 13:37
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit ff1e936 into master Apr 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the update-nox-file-to-build-and-test-wheels branch April 20, 2021 15:02
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@parthea parthea

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify noxfile to build and test the package
3 participants
@parthea @busunkim96 @yoshi-kokoro