Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove repeated calls to self._get_reason #1513

merged 1 commit into from Sep 2, 2021


Copy link

@dermasmid dermasmid commented Sep 2, 2021

self._get_reason is being called in __init__ (#1185) , so why not save it then?
also in the __repr__ function we got the reason by calling the _get_reason function right in the beginning, but was then called again.

parthea approved these changes Sep 2, 2021
Copy link

@parthea parthea left a comment

Thanks for the fix, @dermasmid !

@gcf-merge-on-green gcf-merge-on-green bot merged commit d5cf4e0 into googleapis:main Sep 2, 2021
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants