Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for python 3.10 #1557

Merged
merged 2 commits into from Oct 12, 2021
Merged

feat: add support for python 3.10 #1557

merged 2 commits into from Oct 12, 2021

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Oct 10, 2021

No description provided.

@parthea parthea requested a review from as a code owner Oct 10, 2021
@google-cla google-cla bot added the cla: yes label Oct 10, 2021
@parthea parthea marked this pull request as draft Oct 10, 2021
@busunkim96 busunkim96 self-requested a review Oct 11, 2021
@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Oct 11, 2021

E   AttributeError: module 'collections' has no attribute 'MutableMapping'
_ ERROR collecting .nox/unit-3-10-oauth2client-oauth2client-4-5dev/tmp/tests/test_schema.py _
tests/test_schema.py:22: in <module>
    import unittest2 as unittest
../lib/python3.10/site-packages/unittest2/__init__.py:40: in <module>
    from unittest2.collector import collector
../lib/python3.10/site-packages/unittest2/collector.py:3: in <module>
    from unittest2.loader import defaultTestLoader
../lib/python3.10/site-packages/unittest2/loader.py:13: in <module>
    from unittest2 import case, suite, util
../lib/python3.10/site-packages/unittest2/case.py:18: in <module>
    from unittest2 import result
../lib/python3.10/site-packages/unittest2/result.py:10: in <module>
    from unittest2.compatibility import wraps
../lib/python3.10/site-packages/unittest2/compatibility.py:143: in <module>
    class ChainMap(collections.MutableMapping):
E   AttributeError: module 'collections' has no attribute 'MutableMapping'

If unittest is the issue, we could move over to pytest for consistency with the other repos.

Loading

@tseaver
Copy link
Collaborator

@tseaver tseaver commented Oct 12, 2021

From the PyPI page for unittest2:

unittest2 is a backport of the new features added to the unittest testing framework in Python 2.7 and onwards. It is tested to run on Python 2.6, 2.7, 3.2, 3.3, 3.4 and pypy.

We can just replace it with the stdlib's unittest: see #1564.

Loading

@parthea parthea marked this pull request as ready for review Oct 12, 2021
@parthea parthea merged commit bcc507f into main Oct 12, 2021
11 checks passed
Loading
@parthea parthea deleted the add-python-310-tests branch Oct 12, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 12, 2021
馃 I have created a release \*beep\* \*boop\*
---
## [2.26.0](https://www.github.com/googleapis/google-api-python-client/compare/v2.25.0...v2.26.0) (2021-10-12)


### Features

* add support for python 3.10 ([#1557](https://www.github.com/googleapis/google-api-python-client/issues/1557)) ([bcc507f](https://www.github.com/googleapis/google-api-python-client/commit/bcc507fd7e0ba338cba4afc9c93d9fc577187425))
* **analyticsadmin:** update the api be347fe ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **androidpublisher:** update the api 594b20b ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **appengine:** update the api 59606ed ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **area120tables:** update the api f35db63 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **chromepolicy:** update the api ecaafc4 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **cloudbuild:** update the api 7f6e2e7 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **cloudsearch:** update the api b6310c5 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **container:** update the api 01aebc9 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **content:** update the api 47a7935 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **dialogflow:** update the api 14e2dce ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **dns:** update the api 3e8173d ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **documentai:** update the api fa10141 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **domains:** update the api 9217f62 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **iap:** update the api 178edbd ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **managedidentities:** update the api 6c7bd38 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **osconfig:** update the api 89f87e5 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **redis:** update the api 5e0bac1 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **retail:** update the api 8d4f2af ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **servicenetworking:** update the api b74f86c ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **speech:** update the api 1fe9ba8 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
* **sqladmin:** update the api 1e3c477 ([1c9dcfd](https://www.github.com/googleapis/google-api-python-client/commit/1c9dcfd348b6601c1c5ff0f4f71aee262256377e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants