Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): require uritemplate 3.0.1 #1629

Merged
merged 5 commits into from Dec 13, 2021
Merged

fix(deps): require uritemplate 3.0.1 #1629

merged 5 commits into from Dec 13, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Dec 13, 2021

Fixes #1624 馃

@parthea parthea requested a review from as a code owner Dec 13, 2021
@parthea parthea added kokoro:force-run kokoro:run labels Dec 13, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run kokoro:force-run labels Dec 13, 2021
plamut
plamut approved these changes Dec 13, 2021
Copy link

@plamut plamut left a comment

LGTM, with a non-blocking remark.

# e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev",
# Then this file should have foo==1.14.0
uritemplate==3.0.1
Copy link

@plamut plamut Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we normally pin the minimum version in the constraints file that targets the minimum Python version supported? It would IMO make sense to explain with a comment why this particular constraint lives in the constraints-3.10 file as well (unless this particular library is different).

tswast
tswast approved these changes Dec 13, 2021
Copy link

@tswast tswast left a comment

I agree with Peter that a comment in the 3.10 file would be desirable, but otherwise LGTM

@parthea
Copy link
Contributor Author

@parthea parthea commented Dec 13, 2021

I've reverted the change to testing/constraints-3.10.txt.

@parthea parthea merged commit 1c4cfdb into main Dec 13, 2021
12 checks passed
@parthea parthea deleted the require-uritemplate-3-0-1 branch Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants