Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace '-' in method names with '_' #863

Merged

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Apr 15, 2020

The Healthcare API has a resource named 'Patient-everything' which is unaccessible because the hyphen makes it an invalid name.

https://healthcare.googleapis.com/$discovery/rest?version=v1

          "Patient-everything": {
                          "response": {
                            "$ref": "HttpBody"
                          },

This change replaces the '-' with a '_'.

from googleapiclient import discovery


service = discovery.build("healthcare", "v1")

service.projects().locations().datasets().fhirStores().fhir().Patient_everything(name='...')

CC @noerog

@busunkim96 busunkim96 force-pushed the replace-hyphen-with-underscore branch from 516cf25 to 5b25b32 Apr 15, 2020
@noerog
Copy link

@noerog noerog commented Apr 17, 2020

Hi @busunkim96, if this could be merged it would allow us to submit some Healthcare API PRs that this is blocking.

@busunkim96 busunkim96 requested a review from plamut Apr 17, 2020
@busunkim96 busunkim96 merged commit 8ed729f into googleapis:master Apr 17, 2020
3 checks passed
@noerog
Copy link

@noerog noerog commented Apr 17, 2020

@busunkim96 After this goes in, do you know when the next client release will happen?

@busunkim96
Copy link
Contributor Author

@busunkim96 busunkim96 commented Apr 17, 2020

We have a 'no Friday releases' policy, so I'll cut it on Monday morning. Thank you for your patience!

@noerog
Copy link

@noerog noerog commented Apr 17, 2020

Great, thanks.

@mik-laj
Copy link
Contributor

@mik-laj mik-laj commented Apr 17, 2020

@busunkim96 I am very happy that the release will appear soon. I'm waiting. :-D

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue May 11, 2020
https://build.opensuse.org/request/show/802599
by user mcepl + dimstar_suse
- Update to 1.8.2:
  - Remove apiclient.__version__ gh#googleapis/googleapis#870
  - Adding ConnectionError to retry mechanism gh#googleapis/googleapis#558
  - replace '-' in method names with '_' gh#googleapis/google-api-python-client#863
- Add missing dependency on oauth2client.
- Fix filelist (no CHANGELOG anymore, missing README.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants