Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade repetitive logging calls to debug #885

Merged
merged 2 commits into from Apr 28, 2020

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Apr 24, 2020

Reopens #782 from @bsolomon1124 as that branch is now gone.

The current INFO calls, which are highly repetitive, don't meet
the typical 'severity level' of an INFO message, and are more suited
for DEBUG.

Refs Issue #781

The current INFO calls, which are highly repetitive, don't meet
the typical 'severity level' of an INFO message, and are more suited
for DEBUG.

Refs Issue googleapis#781
@googlebot
Copy link
Collaborator

@googlebot googlebot commented Apr 24, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link
Collaborator

@googlebot googlebot commented Apr 24, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@busunkim96
Copy link
Contributor Author

@busunkim96 busunkim96 commented Apr 24, 2020

CLA was signed in #782

@busunkim96 busunkim96 requested a review from plamut Apr 28, 2020
plamut
plamut approved these changes Apr 28, 2020
Copy link

@plamut plamut left a comment

LGTM.

@busunkim96 busunkim96 merged commit 3bf2781 into googleapis:master Apr 28, 2020
3 checks passed
@busunkim96 busunkim96 deleted the bsolomon1124-master branch Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants