Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the turn down date for global batch uri #901

Merged
merged 2 commits into from May 15, 2020

Conversation

@bradvogel
Copy link
Contributor

@bradvogel bradvogel commented May 14, 2020

Fixes the date of when the global batch endpoint will be turned down, per the extension outlined in https://developers.googleblog.com/2018/03/discontinuing-support-for-json-rpc-and.html.

Fixes the date of when the global batch endpoint will be turned down, per the extension outlined in https://developers.googleblog.com/2018/03/discontinuing-support-for-json-rpc-and.html.
@googlebot
Copy link
Collaborator

@googlebot googlebot commented May 14, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bradvogel
Copy link
Contributor Author

@bradvogel bradvogel commented May 14, 2020

@googlebot I signed it!

@googlebot
Copy link
Collaborator

@googlebot googlebot commented May 14, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented May 14, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented May 14, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented May 15, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@bradvogel
Copy link
Contributor Author

@bradvogel bradvogel commented May 15, 2020

@busunkim96 anything you need from me to merge this?

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented May 15, 2020

@bradvogel Nope, just need to kick CI. Thanks for checking!

@gcf-merge-on-green gcf-merge-on-green bot merged commit 6ddadd7 into googleapis:master May 15, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants