Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't try to import GAE API in other environments #903

Merged
merged 1 commit into from May 14, 2020

Conversation

@zevdg
Copy link
Contributor

@zevdg zevdg commented May 14, 2020

The GAE memcache API isn't supported in python3. This change gives
callers a new way to ensure that googleapiclient doesn't even try
to import and use this legacy API.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #902 馃

@zevdg zevdg changed the title Don't try to import GAE API in other environments chore: don't try to import GAE API in other environments May 14, 2020
The GAE memcache API isn't supported in python3. This change gives
callers a new way to ensure that googleapiclient doesn't even try
to import and use this legacy API.
@busunkim96 busunkim96 changed the title chore: don't try to import GAE API in other environments fix: don't try to import GAE API in other environments May 14, 2020
@busunkim96 busunkim96 merged commit 09e6447 into googleapis:master May 14, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants