Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mtls feature #917

Merged
merged 12 commits into from Jun 2, 2020
Merged

feat: add mtls feature #917

merged 12 commits into from Jun 2, 2020

Conversation

@arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented May 26, 2020

No description provided.

@arithmetic1728 arithmetic1728 marked this pull request as draft May 26, 2020
@busunkim96 busunkim96 self-requested a review May 27, 2020
@arithmetic1728 arithmetic1728 marked this pull request as ready for review May 28, 2020
@arithmetic1728
Copy link
Contributor Author

@arithmetic1728 arithmetic1728 commented May 28, 2020

I think this PR is ready for review. In the unit tests I am using the master branch of python-api-core, will update python-api-core version once the client_encrypted_cert_source is released.

googleapiclient/discovery.py Outdated Show resolved Hide resolved
googleapiclient/discovery.py Show resolved Hide resolved
samples/cloudkms/main.py Outdated Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants