Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update GOOGLE_API_USE_MTLS values #940

Merged
merged 1 commit into from Jun 10, 2020
Merged

fix: update GOOGLE_API_USE_MTLS values #940

merged 1 commit into from Jun 10, 2020

Conversation

@arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Jun 10, 2020

Go client used lower case, so change the values to lower case in python apiary client.

Copy link
Contributor

@busunkim96 busunkim96 left a comment

LGTM. Is it worth making this case insensitive?

@arithmetic1728
Copy link
Contributor Author

@arithmetic1728 arithmetic1728 commented Jun 10, 2020

I think I will just use the lower case to be consistent with the Go implementation: https://github.com/googleapis/google-api-go-client/blob/master/transport/http/dial.go#L31-L35

@arithmetic1728 arithmetic1728 merged commit 19908ed into master Jun 10, 2020
3 checks passed
@arithmetic1728 arithmetic1728 deleted the sijun-name branch Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants