Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Build universal wheels #948

Merged
merged 1 commit into from Jun 26, 2020
Merged

Conversation

@nsoranzo
Copy link
Contributor

nsoranzo commented Jun 25, 2020

See https://packaging.python.org/guides/distributing-packages-using-setuptools/#universal-wheels

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@googlebot
Copy link
Collaborator

googlebot commented Jun 25, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Jun 25, 2020
@nsoranzo
Copy link
Contributor Author

nsoranzo commented Jun 25, 2020

@googlebot I signed it!

@googlebot
Copy link
Collaborator

googlebot commented Jun 25, 2020

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jun 25, 2020
@nsoranzo nsoranzo force-pushed the nsoranzo:patch-1 branch from dc7fa42 to 199a009 Jun 25, 2020
@nsoranzo nsoranzo changed the title Build universal wheels feat: Build universal wheels Jun 25, 2020
@nsoranzo nsoranzo mentioned this pull request Jun 25, 2020
32 of 52 tasks complete
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3e28a1e into googleapis:master Jun 26, 2020
3 checks passed
3 checks passed
Kokoro Build successful
Details
cla/google All necessary CLAs are signed
conventionalcommits.org
Details
@nsoranzo nsoranzo deleted the nsoranzo:patch-1 branch Jun 26, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can鈥檛 perform that action at this time.