Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps)!: require 3.6+ #961

merged 11 commits into from Dec 9, 2020


Copy link

@busunkim96 busunkim96 commented Jul 7, 2020

Removes 2.7 and 3.5 from the test suite and explicitly requires >= 3.6. Also adds tests for 3.9

Fixes #704 馃

@busunkim96 busunkim96 requested a review from crwilcox Jul 7, 2020
@busunkim96 busunkim96 closed this Jul 31, 2020
@busunkim96 busunkim96 reopened this Jul 31, 2020
Copy link

@parthea parthea left a comment

2 minor observations, otherwise looks good! Show resolved Hide resolved Show resolved Hide resolved
@parthea parthea mentioned this pull request Nov 26, 2020
@busunkim96 busunkim96 requested a review from googleapis/yoshi-python as a code owner Dec 9, 2020
busunkim96 added 4 commits Jul 7, 2020
@busunkim96 busunkim96 force-pushed the busunkim96:drop-2-7 branch from a8830a7 to 39d0ed0 Dec 9, 2020
@busunkim96 busunkim96 changed the title chore(deps)!: require 3.5+ chore(deps)!: require 3.6+ Dec 9, 2020
busunkim96 added 3 commits Dec 9, 2020
鈥ent into drop-2-7
@busunkim96 busunkim96 requested a review from parthea Dec 9, 2020
Copy link
Contributor Author

@busunkim96 busunkim96 commented Dec 9, 2020

@parthea Comments have been addressed, PTAL. :)

@busunkim96 busunkim96 mentioned this pull request Dec 9, 2020
4 of 4 tasks complete
parthea approved these changes Dec 9, 2020
Copy link

@parthea parthea left a comment

LGTM, just a minor nit comment Outdated Show resolved Hide resolved
Co-authored-by: Anthonios Partheniou <>
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8325d24 into googleapis:master Dec 9, 2020
3 checks passed
3 checks passed
Kokoro Build successful
cla/google All necessary CLAs are signed
@release-please release-please bot mentioned this pull request Dec 9, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 3, 2021
馃 I have created a release \*beep\* \*boop\* 
## [2.0.0]( (2021-03-03)


* **deps:** require 3.6+ (#961)

### Features

* Add support for using static discovery documents ([#1109]( ([32d1c59](
* Update to copy discovery files from discovery-artifact-manager ([#1104]( ([af918e8](

### Bug Fixes

* Catch ECONNRESET and other errors more reliably ([#1147]( ([ae9cd99](
* **deps:** add upper-bound google-auth dependency ([#1180]( ([c687f42](
* handle error on service not enabled ([#1117]( ([c691283](
* Improve support for error_details ([#1126]( ([e6a1da3](
* MediaFileUpload error if file does not exist ([#1127]( ([2c6d029](
* replace deprecated socket.error with OSError ([#1161]( ([b7b9986](
* Use logging level info when file_cache is not available ([#1125]( ([0b32e69](

### Miscellaneous Chores

* **deps:** require 3.6+ ([#961]( ([8325d24](

### Documentation

* add networkconnectivity v1alpha1 ([#1176]( ([91b61d3](
* Delete redundant ([#1142]( ([70bc6c9](
* fix MediaIoBaseUpload broken link ([#1112]( ([334b6e6](
* fix regression with incorrect args order in docs ([#1141]( ([4249a7b](
* fix typo in thread safety example code ([#1100]( ([5ae088d](
* Reduce noisy changes in docs regen ([#1135]( ([b1b0c83](
* update docs/dyn ([#1096]( ([c2228be](
* update guidance on service accounts ([#1120]( ([b2ea122](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants