Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discovery uses V2 when version is None #975

Merged
merged 1 commit into from Jul 30, 2020

Conversation

@DFrenkel
Copy link
Contributor

@DFrenkel DFrenkel commented Jul 21, 2020

Passing version=None to discovery.build(), with intent to always
get the latest version of the discovery document,
no longer attempts to use Discovery V1, which fails with
Bad Request errors.
Instead, it uses Discovery V2, which supports null version use case.

Fixes: #971

@google-cla google-cla bot added the cla: yes label Jul 21, 2020
Passing version=None to discovery.build(), with intent to always
get the latest version of the discovery document,
no longer attempts to use Discovery V1, which fails with
Bad Request errors.
Instead, it uses Discovery V2, which supports null version use case.

Fixes: googleapis#971
@DFrenkel DFrenkel force-pushed the discovery-vnone branch from 28f2f1c to 7fa9958 Jul 23, 2020
@busunkim96 busunkim96 self-requested a review Jul 25, 2020
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Jul 25, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Jul 25, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@DFrenkel
Copy link
Contributor Author

@DFrenkel DFrenkel commented Jul 28, 2020

Kokoro test run seems to have timed out. Could repo owners please kick off another run to unblock the merge? Thanks!

@gcf-merge-on-green gcf-merge-on-green bot merged commit cd4e8f4 into googleapis:master Jul 30, 2020
3 of 4 checks passed
@DFrenkel DFrenkel deleted the discovery-vnone branch Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants