New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when :params_encoder is set incorrectly. #5

Closed
sporkmonger opened this Issue Aug 12, 2012 · 0 comments

Comments

Projects
None yet
2 participants
@sporkmonger
Collaborator

sporkmonger commented Aug 12, 2012

Once technoweenie/faraday#182 is resolved, we're going to need to handle connections differently.

First, this probably means we need to use Google::APIClient.default_connection instead of Faraday.default_connection since the default value Faraday uses will likely be wrong for our use-case. But we also allow users to supply their own connection objects. Since the majority of time having the wrong setting won't cause problems, I'm inclined to make the condition where :params_encoder is set to Faraday::NestedParamsEncoder just a warning, but it's definitely something we need to check for.

@sqrrrl sqrrrl added the obsolete label Jan 8, 2016

@sqrrrl sqrrrl closed this Jan 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment