Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 2.5 support #648

Merged
merged 2 commits into from Mar 22, 2018

Conversation

@sponomarev
Copy link
Contributor

commented Jan 16, 2018

Hi there!

Accordingly, to this commit ruby/ruby@0078e40, multiline headers are no more acceptable. It's a pity, but the library generates User-Agent with OS version which contains trailing newline.

This PR solves the issue and add explicit Ruby 2.4 and 2.5 support to test against on CI.

@googlebot

This comment has been minimized.

Copy link

commented Jan 16, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no label Jan 16, 2018

@sponomarev sponomarev force-pushed the sponomarev:fix/ruby-2.5 branch from 770b7a3 to 5389945 Jan 17, 2018

@coveralls

This comment has been minimized.

Copy link

commented Jan 18, 2018

Coverage Status

Coverage decreased (-0.09%) to 95.991% when pulling 5389945 on sponomarev:fix/ruby-2.5 into 8504b3d on google:master.

@sponomarev sponomarev force-pushed the sponomarev:fix/ruby-2.5 branch from 5389945 to 40f78b2 Jan 18, 2018

@brchristian

This comment has been minimized.

Copy link

commented Jan 26, 2018

@sqrrrl This issue with Ruby 2.5 compatibility which this PR addresses is a showstopper for us and for anyone trying to use the google-api-ruby-client gem with Ruby 2.5 (and higher). Let me know if there is anything we can do to help get this PR merged!

@sponomarev

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2018

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Feb 1, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Feb 1, 2018

dentarg referenced this pull request in dentarg/skuld Mar 5, 2018
@hasghari

This comment has been minimized.

Copy link

commented Mar 14, 2018

Any resolution to this issue?

@sponomarev

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2018

Hey @grant, sorry for bugging you! Any chance that it could be merged? A lot of production projects are suffering...

@grant grant merged commit 3bffde3 into googleapis:master Mar 22, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sponomarev sponomarev deleted the sponomarev:fix/ruby-2.5 branch Mar 22, 2018

hmnhf added a commit to Taskulu/google-api-ruby-client that referenced this pull request Apr 5, 2018
Fix user agent header field value error
* Multi-line headers are no longer acceptable.
* googleapis#648
@pfeiffer pfeiffer referenced this pull request Aug 9, 2018
mattysweeps added a commit to cloudfoundry-community/stackdriver-tools that referenced this pull request Jan 15, 2019
Update google-client-apis gem for fluentd
To fix a bug with multiline syslog messages:
googleapis/google-api-ruby-client#648
mattysweeps added a commit to cloudfoundry-community/stackdriver-tools that referenced this pull request Jan 15, 2019
domhnallmurphy-examtime added a commit to ExamTime/google-api-ruby-client that referenced this pull request Jan 18, 2019
winebarrel added a commit to muuseo/google-api-ruby-client that referenced this pull request Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.