Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to gemfile to fix specs #707

Merged
merged 3 commits into from Aug 22, 2018

Conversation

Projects
None yet
4 participants
@dazuma
Copy link
Contributor

commented Aug 22, 2018

It looks like the logging gem used to be in the bundle implicitly due to a transitive dependency, but has been removed. This is why the tests have been breaking. Adding it explicitly because the spec helper requires it.

@googlebot googlebot added the cla: yes label Aug 22, 2018

@dazuma dazuma requested a review from google/yoshi-ruby Aug 22, 2018

@coveralls

This comment has been minimized.

Copy link

commented Aug 22, 2018

Coverage Status

Coverage increased (+0.07%) to 96.064% when pulling b33c970 on dazuma:logging-fix into 24be95a on google:master.

@dazuma

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2018

Also made two more changes:

  • Removed two enormous puts calls that were overwhelming the travis logs and making test output useless.
  • Added the new Signet::RemoteServerError (see googleapis/signet#100) to the list of retriable auth errors, to make HttpCommand tests pass.

@dazuma dazuma merged commit 406fcb0 into googleapis:master Aug 22, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dazuma dazuma deleted the dazuma:logging-fix branch Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.