Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize type: Date values #776

Merged
merged 2 commits into from May 10, 2019

Conversation

Projects
None yet
7 participants
@RedBulli
Copy link
Contributor

commented Mar 19, 2019

According to https://www.rubydoc.info/github/google/google-api-ruby-client/Google/Apis/CalendarV3/EventDateTime#date-instance_method the date should be parsed to a Date, but currently it is only a "yyyy-mm-dd" string.

RedBulli added some commits Mar 19, 2019

@googlebot googlebot added the cla: yes label Mar 19, 2019

@RedBulli RedBulli changed the title Deserialize Date type values Deserialize type: Date values Mar 19, 2019

@blowmage
Copy link
Contributor

left a comment

I'm cautiously approving. I worry about unintended consequences here, but I also don't see a reason not to fix this behavior.

@TheRoyalTnetennba TheRoyalTnetennba merged commit 812b374 into googleapis:master May 10, 2019

4 checks passed

OSx Build successful
Details
Ubuntu Build successful
Details
Windows Build successful
Details
cla/google All necessary CLAs are signed
@quartzmo

This comment has been minimized.

Copy link

commented May 28, 2019

As @blowmage feared, this change led to unit test failures in google-cloud-storage (fixed in googleapis/google-cloud-ruby#3417).

@blowmage

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

The joys of using a library that has never reached 1.0...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.