Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mime-types dependency with mini_mime #789

Merged
merged 2 commits into from May 13, 2019

Conversation

Projects
None yet
5 participants
@bborn
Copy link
Contributor

commented May 10, 2019

Replaced mime-types with mini_mime. Specs are passing.

@googlebot

This comment has been minimized.

Copy link

commented May 10, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label May 10, 2019

@bborn

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Signed the CLA

@googlebot

This comment has been minimized.

Copy link

commented May 10, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 10, 2019

Show resolved Hide resolved google-api-client.gemspec Outdated
Update google-api-client.gemspec
Co-Authored-By: Mike Moore <mike@blowmage.com>
@googlebot

This comment has been minimized.

Copy link

commented May 10, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@TheRoyalTnetennba TheRoyalTnetennba added cla: yes and removed cla: no labels May 13, 2019

@googlebot

This comment has been minimized.

Copy link

commented May 13, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@TheRoyalTnetennba TheRoyalTnetennba merged commit c1a26e0 into googleapis:master May 13, 2019

4 checks passed

OSx Build successful
Details
Ubuntu Build successful
Details
Windows Build successful
Details
cla/google CLAs have been manually verified by Googler who has set the 'cla: yes' label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.