Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Customize name for an unsupported domainsrdap call #826

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@dazuma
Copy link
Contributor

commented Sep 10, 2019

Codegen has been failing since Aug 26 because two calls (/domainsrdap:v1/domainsrdap.getIp and /domainsrdap:v1/domainsrdap.ip.get) in the new domainsrdap client are mapping to the same method name (get_ip). Overriding the mapping of the latter to ip_get. (Note that according to the documentation this call is not supported anyway and always returns a 5xx.)

@blowmage

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

This LGTM. The failed CI builds don't seem to be related. Does the build even test this file?

@dazuma

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

I think that failure has been happening for a while in this repo. @TheRoyalTnetennba help?

@dazuma

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

@blowmage The tests do load that file, but they don't actually run through all the library generation and so won't actually test that entry in particular.

Copy link
Contributor

left a comment

🎉

@dazuma dazuma merged commit 39975ca into googleapis:master Sep 10, 2019
2 of 4 checks passed
2 of 4 checks passed
Ubuntu Build failed
Details
Windows Build failed
Details
OSx Build successful
Details
cla/google All necessary CLAs are signed
@dazuma dazuma deleted the dazuma:fix-domainsrdap branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.