Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes to specs #827

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@dazuma
Copy link
Contributor

commented Sep 11, 2019

I don't think these are related at all to the current CI failures, but here are two fixes to the specs that are causing other issues.

  • One matcher puts an OS name/version string in a Regexp, but in some environments (such as my local Linux) this string contains Regexp special characters (notably +). Escape the string before embedding in a Regexp.
  • A second matcher is checking for the body posted in an http request, and includes a Content-Length header. This header's value depends on the ruby version and the gem version, and started failing when the gem version's length changed (0.30.9 -> 0.30.10). Change the matcher to match on a regexp instead of a literal string, and loosen the check on Content-Length.
@dazuma dazuma requested a review from blowmage Sep 11, 2019
@googlebot googlebot added the cla: yes label Sep 11, 2019
@dazuma dazuma merged commit b03725c into googleapis:master Sep 11, 2019
2 of 4 checks passed
2 of 4 checks passed
Ubuntu Build failed
Details
Windows Build failed
Details
OSx Build successful
Details
cla/google All necessary CLAs are signed
@dazuma dazuma deleted the dazuma:spec-fix branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.